Prevent development welcome route from duplicating on route reload#57367
Open
curi wants to merge 1 commit into
Open
Prevent development welcome route from duplicating on route reload#57367curi wants to merge 1 commit into
curi wants to merge 1 commit into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Rails registers its internal development welcome route from
routes_reloader.run_after_load_paths.That hook currently calls
app.routes.appendon each route reload.RouteSet#appendstores append blocks persistently, while route reloads clear and finalize the realized routes. As a result, repeatedreload_routes!calls in development add another internalGET /welcome route each time.Detail
Register the internal welcome route append block only once per application boot, while preserving the existing
appendbehavior and route ordering. This keeps app-appended root routes taking precedence over the internal welcome route.Additional information
No existing issue found for this specific duplicate welcome-route behavior.
Tests
ruby -c railties/lib/rails/application/finisher.rbruby -c railties/test/application/routing_test.rbbundle exec rubocop railties/lib/rails/application/finisher.rb railties/test/application/routing_test.rbcd railties && bin/test test/application/routing_test.rb -i '/not duplicated|appended root/'cd railties && bin/test test/application/routing_test.rb