FIX: Select better featured posters#39691
Open
curi wants to merge 1 commit intodiscourse:mainfrom
Open
Conversation
github-actions
Bot
added
the
i18n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug where the frequent posters were reordered by the date of their most recent post in the topic, with older posts preferred. This hid posters who should have been displayed (e.g. someone with the most posts and the second most recent post). This PR fixes the bug and improves the selection with better visibility for recent discussion and new participants.
Bug report showing the issue with screenshots: https://meta.discourse.org/t/frequent-posters-shown-on-latest-page/235281
New display logic: The topic list shows up to five posters in this order: the OP, two frequent posters, and two recent posters. Recent posters are excluded from frequent posters, and the OP is excluded from both. The latest poster is handled separately and replaces a recent poster unless the OP is the latest poster.